Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/disable jitify lto #12122

Merged

Conversation

robertmaynard
Copy link
Contributor

Description

Remove the possiblity of jit lto from cudf

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 5 - DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Nov 10, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner November 10, 2022 17:24
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Nov 10, 2022
@robertmaynard
Copy link
Contributor Author

Waiting on rapidsai/jitify#15 to be merged so we can use the rapidsai fork

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 87.47% // Head: 88.09% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (b01465d) compared to base (f817d96).
Patch has no changes to coverable lines.

❗ Current head b01465d differs from pull request most recent head 4e767e5. Consider uploading reports for the commit 4e767e5 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12122      +/-   ##
================================================
+ Coverage         87.47%   88.09%   +0.61%     
================================================
  Files               133      135       +2     
  Lines             21826    22100     +274     
================================================
+ Hits              19093    19469     +376     
+ Misses             2733     2631     -102     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 76.47% <0.00%> (-7.85%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Nov 15, 2022
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bae9e39 into rapidsai:branch-22.12 Nov 15, 2022
@robertmaynard robertmaynard deleted the fix/disable_jitify_lto branch November 15, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants