Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlinks to notebooks. #12128

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 10, 2022

Description

Adds symlinks to notebooks from the user guide as requested by @taureandyernv.

Going forward, new notebooks added to the user guide directory should also be symlinked in /notebooks.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner November 10, 2022 21:59
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bdice bdice self-assigned this Nov 10, 2022
@bdice bdice added the doc Documentation label Nov 10, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 10, 2022
@bdice bdice added non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Nov 10, 2022
@galipremsagar
Copy link
Contributor

@gpucibot merge

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 87.47% // Head: 88.09% // Increases project coverage by +0.61% 🎉

Coverage data is based on head (3cb42c6) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12128      +/-   ##
================================================
+ Coverage         87.47%   88.09%   +0.61%     
================================================
  Files               133      135       +2     
  Lines             21826    22100     +274     
================================================
+ Hits              19093    19469     +376     
+ Misses             2733     2631     -102     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 76.47% <0.00%> (-7.85%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rapids-bot rapids-bot bot merged commit f87d2b4 into rapidsai:branch-22.12 Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants