Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on GNU find in headers_test.sh #12164

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Nov 16, 2022

Description

-printf is a GNU find extension, so headers_test.sh fails on systems where binutils is a BSD toolchain.

To get around this, use sed to obtain the effect of -printf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner November 16, 2022 11:48
@github-actions github-actions bot added the gpuCI label Nov 16, 2022
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2022
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 87.47% // Head: 88.14% // Increases project coverage by +0.66% 🎉

Coverage data is based on head (3dd1b90) compared to base (f817d96).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12164      +/-   ##
================================================
+ Coverage         87.47%   88.14%   +0.66%     
================================================
  Files               133      135       +2     
  Lines             21826    22126     +300     
================================================
+ Hits              19093    19503     +410     
+ Misses             2733     2623     -110     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 85.45% <0.00%> (-9.10%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/cudf/cudf/io/json.py 92.06% <0.00%> (-2.68%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/core/column/timedelta.py 90.17% <0.00%> (-0.58%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.21% <0.00%> (-0.51%) ⬇️
python/cudf/cudf/core/column/column.py 87.96% <0.00%> (-0.46%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/cudf/cudf/io/parquet.py 90.45% <0.00%> (-0.39%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ci/checks/headers_test.sh Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Nov 16, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ae101cc into rapidsai:branch-22.12 Nov 16, 2022
@wence- wence- deleted the wence/fix/no-gnu-find branch November 16, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants