Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix from_dict backend dispatch to match upstream dask #12203

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

galipremsagar
Copy link
Contributor

Description

This PR fixes a failure being observed in dask upstream: dask/dask#9676

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 18, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner November 18, 2022 17:46
@galipremsagar galipremsagar self-assigned this Nov 18, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 18, 2022
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 18, 2022
@galipremsagar galipremsagar requested review from a team as code owners November 18, 2022 19:15
@galipremsagar galipremsagar requested review from vyasr and bdice and removed request for a team November 18, 2022 19:15
@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Nov 18, 2022
@galipremsagar galipremsagar removed the request for review from a team November 18, 2022 19:16
@galipremsagar galipremsagar removed request for a team, vyasr and bdice November 18, 2022 19:16
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. conda CMake CMake build issue Java Affects Java cuDF API. labels Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 88.25% // Head: 88.22% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (5913773) compared to base (782fba3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12203      +/-   ##
================================================
- Coverage         88.25%   88.22%   -0.04%     
================================================
  Files               137      137              
  Lines             22571    22571              
================================================
- Hits              19921    19914       -7     
- Misses             2650     2657       +7     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/backends.py 85.17% <ø> (ø)
python/cudf/cudf/core/column/lists.py 92.78% <0.00%> (-0.97%) ⬇️
python/cudf/cudf/core/column/decimal.py 91.35% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 84.19% <0.00%> (-0.31%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 91.30% <0.00%> (-0.21%) ⬇️
python/cudf/cudf/core/column/string.py 88.52% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/core/dataframe.py 93.59% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ajschmidt8 ajschmidt8 merged commit 21ba312 into rapidsai:branch-22.12 Nov 18, 2022
@rjzamora
Copy link
Member

Thank you for fixing this @galipremsagar and thanks for merging @ajschmidt8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants