Workaround for CUB segmented-sort bug with boolean keys #12217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
bug
davidwendt
requested review from
bdice and
mythrocks
and removed request for
a team
bdice
approved these changes
Nov 21, 2022
Codecov ReportBase: 88.25% // Head: 88.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12217 +/- ##
=============================================
Coverage 88.25% 88.25%
=============================================
Files 137 137
Lines 22571 22571
=============================================
Hits 19921 19921
Misses 2650 2650 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
elstehle
approved these changes
Nov 22, 2022
|
Waiting on Spark to verify this change passes their tests. |
jlowe
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Thanks, @davidwendt! Spark tests that were failing before this change are now passing.
jolorunyomi
approved these changes
Nov 22, 2022
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
Fix in CUB DeviceSegmentedSort allows for workaround to removed. The CUB fix is applied as a patch in the libcudf build process. Reference NVIDIA/cub#594 and #12217 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Elias Stehle (https://github.com/elstehle) - Robert Maynard (https://github.com/robertmaynard) URL: #12234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a workaround for
cudf::segmented_sortwhen following the optimized path with a the key type ofbool.Here, the optimized path is avoided by checking the column-type.
A gtest is also included for this case.
The workaround can be removed once NVIDIA/cub#594 is fixed and available for libcudf.
Closes #12201
Checklist