-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dask pinning looser #12231
Make dask pinning looser #12231
Conversation
I'm going to reenable the wheel building process temporarily to ensure that wheels build successfully with these changes before we merge. |
Wheels build successfully and at least locally the new cudf wheels resolve the dask/distributed dependency resolution issues I ran into during other wheel builds. This PR should be good to merge unless @galipremsagar has a different preference on how we should handle this pinning/unpinning in conjunction with #12165. |
Codecov ReportBase: 88.25% // Head: 88.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12231 +/- ##
=============================================
Coverage 88.25% 88.25%
=============================================
Files 137 137
Lines 22571 22571
=============================================
Hits 19921 19921
Misses 2650 2650 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vyasr !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vyasr ! Lets admin merge this now since actual dask pinning is going to happen on this month's end.
Description
This PR relaxes the pinning of dask and distributed for 22.12 so that it can be updated in lockstep with other packages in #12165. The current strict pinning causes problems for all downstream RAPIDS packages that have cudf as a pip dependency.
Checklist