Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dask pinning looser #12231

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 22, 2022

Description

This PR relaxes the pinning of dask and distributed for 22.12 so that it can be updated in lockstep with other packages in #12165. The current strict pinning causes problems for all downstream RAPIDS packages that have cudf as a pip dependency.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr requested a review from a team as a code owner November 22, 2022 23:10
@vyasr vyasr self-assigned this Nov 22, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 22, 2022
@vyasr vyasr changed the title Make pinning >=. Make dask pinning looser Nov 22, 2022
@vyasr vyasr added ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround non-breaking Non-breaking change bug Something isn't working labels Nov 22, 2022
@vyasr vyasr requested a review from a team as a code owner November 22, 2022 23:21
@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 22, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Nov 22, 2022

I'm going to reenable the wheel building process temporarily to ensure that wheels build successfully with these changes before we merge.

@vyasr vyasr removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 23, 2022
@vyasr
Copy link
Contributor Author

vyasr commented Nov 23, 2022

Wheels build successfully and at least locally the new cudf wheels resolve the dask/distributed dependency resolution issues I ran into during other wheel builds. This PR should be good to merge unless @galipremsagar has a different preference on how we should handle this pinning/unpinning in conjunction with #12165.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 88.25% // Head: 88.25% // No change to project coverage 👍

Coverage data is based on head (cf0ff11) compared to base (ed35f67).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.12   #12231   +/-   ##
=============================================
  Coverage         88.25%   88.25%           
=============================================
  Files               137      137           
  Lines             22571    22571           
=============================================
  Hits              19921    19921           
  Misses             2650     2650           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @vyasr !

Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyasr ! Lets admin merge this now since actual dask pinning is going to happen on this month's end.

@jjacobelli jjacobelli merged commit 0c60819 into rapidsai:branch-22.12 Nov 23, 2022
@vyasr vyasr deleted the hotfix/dask_version branch November 23, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants