JNI changes for range-extents in window functions. #13199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds back-end JNI changes to support explicit range-extents for ranged window functions. The change is analogous to the addition of `cudf::range_window_bounds::extent_type`, in `libcudf`. This change will allow for `STRING` order-by columns for range window functions. It is required because without it, it would be impossible to differentiate between `UNBOUNDED` and `CURRENT ROW` for a window function over a `STRING` order-by column.
mythrocks
added
feature request
ttnghia
reviewed
Apr 22, 2023
ttnghia
approved these changes
Apr 22, 2023
revans2
approved these changes
Apr 24, 2023
|
/merge |
mythrocks
added a commit
to NVIDIA/spark-rapids
that referenced
this pull request
Apr 27, 2023
Closes #7883. Depends on rapidsai/cudf#13143, rapidsai/cudf#13199. This commit adds support for `STRING` order-by columns for RANGE window functions. Before this commit, only numeric and timestamp types were supported as order-by columns in window specifications. However, it is possible to specify window frames such as follows: ```sql SELECT COUNT(1) OVER( PARTITION BY gid ORDER BY str_col ) ``` The implicit range here is `UNBOUNDED PRECEDING AND CURRENT ROW`, although explicit bounds may also be specified. Note that range values cannot be specified here, because `STRING` does not support intervals. This change should now allow the plugin to support `UNBOUNDED PRECEDING`, `UNBOUNDED FOLLOWING`, and `CURRENT ROW` as range window bounds, when the order-by column is `STRING`. Signed-off-by: MithunR <mythrocks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds back-end JNI changes to support explicit range-extents for ranged window functions. The change is analogous to the addition of
cudf::range_window_bounds::extent_type, inlibcudf. This change will allow forSTRINGorder-by columns for range window functions. It is required because without it, it would be impossible to differentiate betweenUNBOUNDEDandCURRENT ROWfor a window function over aSTRINGorder-by column.Checklist