-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable fractional null probability for hashing benchmark #13967
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-23.10
from
Blonck:processed_bytes_hash_nvbench
Aug 30, 2023
Merged
Enable fractional null probability for hashing benchmark #13967
rapids-bot
merged 9 commits into
rapidsai:branch-23.10
from
Blonck:processed_bytes_hash_nvbench
Aug 30, 2023
Commits on Aug 25, 2023
-
Enable fractional null probability for hashing benchmark
In the past, the `HASING_NVBENCH` benchmark treated the `nulls` parameter as a boolean. Any value other than 0.0 resulted in a null probability of 100% for the generated data. Now, the `nulls` parameter directly determines the null probability. For instance, a value of 0.1 will generate 10% of the data as null. Moreover, setting nulls to 0.0 produces data without a null bitmask. Additionally, `bytes_per_second` are added to the benchmark. This patch relates to rapidsai#13735.
Martin Marenz committedAug 25, 2023 Configuration menu - View commit details
-
Copy full SHA for 3e0cd91 - Browse repository at this point
Copy the full SHA 3e0cd91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5c6db - Browse repository at this point
Copy the full SHA 2a5c6dbView commit details
Commits on Aug 26, 2023
-
Fix memory statistics for hashing benchmark
Co-authored-by: Yunsong Wang <yunsongw@nvidia.com>
Configuration menu - View commit details
-
Copy full SHA for dc2556b - Browse repository at this point
Copy the full SHA dc2556bView commit details -
Add missing include in hashing benmchmark
Martin Marenz committedAug 26, 2023 Configuration menu - View commit details
-
Copy full SHA for c229367 - Browse repository at this point
Copy the full SHA c229367View commit details
Commits on Aug 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 495f674 - Browse repository at this point
Copy the full SHA 495f674View commit details
Commits on Aug 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9a930cb - Browse repository at this point
Copy the full SHA 9a930cbView commit details
Commits on Aug 30, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 41303b3 - Browse repository at this point
Copy the full SHA 41303b3View commit details -
Change wording in hashing benchmark
Code review suggestions. Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 47d8d84 - Browse repository at this point
Copy the full SHA 47d8d84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 74d798f - Browse repository at this point
Copy the full SHA 74d798fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.