Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add JNI bindings for integers_to_hex #14205

Merged
merged 4 commits into from
Sep 27, 2023
Merged

[Java] Add JNI bindings for integers_to_hex #14205

merged 4 commits into from
Sep 27, 2023

Conversation

razajafri
Copy link
Contributor

Description

This PR adds a method to ColumnView class to allow for conversion from Integers to hex
closes #14081

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@razajafri razajafri added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Sep 27, 2023
@razajafri razajafri requested a review from a team as a code owner September 27, 2023 01:20
@razajafri razajafri self-assigned this Sep 27, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 27, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Java Affects Java cuDF API. label Sep 27, 2023
@razajafri
Singing off
2146b33 
Signed-off-by: Raza Jafri <rjafri@nvidia.com>
kuhushukla
kuhushukla approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

revans2
revans2 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit about the docs

java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
@razajafri
Copy link
Contributor Author

/ok to test

@razajafri
Copy link
Contributor Author

/ok to test

@razajafri razajafri mentioned this pull request Sep 27, 2023
Merged
@razajafri
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bff0fcd into rapidsai:branch-23.10 Sep 27, 2023
57 checks passed
@razajafri razajafri deleted the CUDF-14081-integers-to-hex branch September 27, 2023 18:25
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@kuhushukla kuhushukla kuhushukla approved these changes

Assignees

@razajafri razajafri

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA][JNI] Add JNI bindings for cudf::strings::integers_to_hex()
4 participants
@razajafri @revans2 @kuhushukla @vyasr