cudf::detail::pinned_allocator doesn't throw from deallocate
#14251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rapidsai#14165 The deallocate function is called by the `pinned_host_vector`. Throwing from destructors is bad since they can't be caught, and generally get converted into runtime sig aborts.
robertmaynard
added
bug
davidwendt
approved these changes
Oct 5, 2023
divyegala
reviewed
Oct 5, 2023
divyegala
approved these changes
Oct 5, 2023
|
/merge |
hyperbolic2346
approved these changes
Oct 5, 2023
robertmaynard
deleted the
bug/remove_throwing_deallocate_pinned_host_vector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14165
The deallocate function is called by the
pinned_host_vector. Throwing from destructors is bad since they can't be caught, and generally get converted into runtime sig aborts.Checklist