Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some doxygen improvements #14469

Merged
merged 8 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cpp/include/cudf/ast/expressions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@

namespace cudf {
namespace ast {
/**
* @addtogroup expressions
* @{
* @file
*/

// Forward declaration.
namespace detail {
Expand Down Expand Up @@ -544,6 +549,7 @@ class column_name_reference : public expression {
std::string column_name;
};

/** @} */ // end of group
} // namespace ast

} // namespace cudf
2 changes: 2 additions & 0 deletions cpp/include/cudf/column/column_device_view.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ namespace cudf {
* If used at compile-time, this indicator can tell the optimizer
* to include or exclude any null-checking clauses.
*
* @ingroup column_classes
*
*/
struct nullate {
struct YES : std::bool_constant<true> {};
Expand Down
12 changes: 6 additions & 6 deletions cpp/include/cudf/dictionary/update_keys.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ namespace dictionary {
* Null entries from the input column are copied to the output column.
* No new null entries are created by this operation.
*
* @throw cudf_logic_error if the new_keys type does not match the keys type in
* @throw cudf::logic_error if the new_keys type does not match the keys type in
* the dictionary_column.
* @throw cudf_logic_error if the new_keys contain nulls.
* @throw cudf::logic_error if the new_keys contain nulls.
*
* @param dictionary_column Existing dictionary column.
* @param new_keys New keys to incorporate into the dictionary_column.
Expand Down Expand Up @@ -78,9 +78,9 @@ std::unique_ptr<column> add_keys(
* @endcode
* Note that "a" has been removed so output row[2] becomes null.
*
* @throw cudf_logic_error if the keys_to_remove type does not match the keys type in
* @throw cudf::logic_error if the keys_to_remove type does not match the keys type in
* the dictionary_column.
* @throw cudf_logic_error if the keys_to_remove contain nulls.
* @throw cudf::logic_error if the keys_to_remove contain nulls.
*
* @param dictionary_column Existing dictionary column.
* @param keys_to_remove The keys to remove from the dictionary_column.
Expand Down Expand Up @@ -134,9 +134,9 @@ std::unique_ptr<column> remove_unused_keys(
* d2 is now {keys=["b", "c", "d"], indices=[1, x, 0, 1, 0], valids=[1, 0, 1, 1, 1]}
* @endcode
*
* @throw cudf_logic_error if the keys type does not match the keys type in
* @throw cudf::logic_error if the keys type does not match the keys type in
* the dictionary_column.
* @throw cudf_logic_error if the keys contain nulls.
* @throw cudf::logic_error if the keys contain nulls.
*
* @param dictionary_column Existing dictionary column.
* @param keys New keys to use for the output column. Must not contain nulls.
Expand Down
7 changes: 7 additions & 0 deletions cpp/include/cudf/io/types.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ class datasource;
namespace cudf {
//! IO interfaces
namespace io {
/**
* @addtogroup io_types
* @{
* @file
*/

/**
* @brief Compression algorithms
*/
Expand Down Expand Up @@ -938,5 +944,6 @@ class reader_column_schema {
[[nodiscard]] size_t get_num_children() const { return children.size(); }
};

/** @} */ // end of group
} // namespace io
} // namespace cudf
6 changes: 3 additions & 3 deletions cpp/include/cudf/lists/lists_column_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@ class lists_column_view : private column_view {
/**
* @brief Returns the internal column of offsets
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
* @return The internal column of offsets
*/
[[nodiscard]] column_view offsets() const;

/**
* @brief Returns the internal child column
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
* @return The internal child column
*/
[[nodiscard]] column_view child() const;
Expand All @@ -104,7 +104,7 @@ class lists_column_view : private column_view {
* the child columns when recursing. Most functions operating in a recursive manner
* on lists columns should be using `get_sliced_child()` instead of `child()`.
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
* @param stream CUDA stream used for device memory operations and kernel launches
* @return A sliced child column view
*/
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/strings/strings_column_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class strings_column_view : private column_view {
/**
* @brief Returns the internal column of offsets
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
* @return The offsets column
*/
[[nodiscard]] column_view offsets() const;
Expand All @@ -106,7 +106,7 @@ class strings_column_view : private column_view {
/**
* @brief Returns the internal column of chars
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
* @return The chars column
*/
[[nodiscard]] column_view chars() const;
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf/structs/structs_column_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class structs_column_view : public column_view {
* the child columns when recursing. Most functions operating in a recursive manner
* on struct columns should be using `get_sliced_child()` instead of `child()`.
*
* @throw cudf::logic error if this is an empty column
* @throw cudf::logic_error if this is an empty column
*
* @param index The index of the child column to return
* @param stream The stream on which to perform the operation. Uses the default CUDF
Expand Down
8 changes: 7 additions & 1 deletion cpp/include/cudf/utilities/default_stream.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2020-2022, NVIDIA CORPORATION.
* Copyright (c) 2020-2023, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -22,6 +22,11 @@
#include <rmm/cuda_stream_view.hpp>

namespace cudf {
/**
* @addtogroup default_stream
* @{
* @file
*/

/**
* @brief Get the current default stream
Expand All @@ -37,4 +42,5 @@ rmm::cuda_stream_view const get_default_stream();
*/
bool is_ptds_enabled();

/** @} */ // end of group
} // namespace cudf
8 changes: 8 additions & 0 deletions cpp/include/cudf/utilities/span.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,13 @@ class span_base {

} // namespace detail

/**
* @addtogroup utility_span
* @{
* @file
* @brief APIs for labeling values by bin.
*/

// ===== host_span =================================================================================

template <typename T>
Expand Down Expand Up @@ -318,6 +325,7 @@ struct device_span : public cudf::detail::span_base<T, Extent, device_span<T, Ex
{
}
};
/** @} */ // end of group

namespace detail {

Expand Down
3 changes: 3 additions & 0 deletions cpp/include/doxygen_groups.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
// Add a new group by first specifying in the hierarchy below.

/**
* @defgroup default_stream Default Stream
* @defgroup cudf_classes Classes
* @{
* @defgroup column_classes Column
Expand Down Expand Up @@ -179,9 +180,11 @@
* @defgroup utility_dispatcher Type Dispatcher
* @defgroup utility_bitmask Bitmask
* @defgroup utility_error Exception
* @defgroup utility_span Exception
* @}
* @defgroup labeling_apis Labeling
* @{
* @defgroup label_bins Bin Labeling
* @}
* @defgroup expressions Expression Evaluation
*/