Drop llvm16 from cuda118-conda devcontainer image

[charlesbluca]

Description

Looks like the old image used for cuda11.8-conda no longer exists:

[-26553 ms] Error response from daemon: No such image: rapidsai/devcontainers:24.02-cpp-llvm16-cuda11.8-mambaforge-ubuntu22.04

On the suggestion of @trxcllnt, trying out 24.02-cpp-cuda11.8-mambaforge-ubuntu22.04 instead.

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[bdice]

/ok to test

[bdice]

@charlesbluca This won't be tested by CI -- only CUDA 12 images are tested in CI. If you can verify that this works locally, I will approve and merge it.

[bdice]

Is a similar change needed here for CUDA 11.8 + pip? https://github.com/charlesbluca/cudf/blob/75cebe9382c69994f89953f004c732b302c9fd6e/.devcontainer/cuda11.8-pip/devcontainer.json#L8

[charlesbluca]

Yup, good catch @bdice - can make the change there too and will follow up after verifying the devcontainer builds for cuda11.8-conda|pip

[charlesbluca]

Actually on second thought, it looks like the tag for cuda11.8-pip does exist:

https://hub.docker.com/layers/rapidsai/devcontainers/24.02-cpp-llvm16-cuda11.8-ubuntu22.04/images/sha256-250ef49bde099444f4532915423ca91a0e5d803c4921fb30d68dcac4819d65fe?context=explore

Given the fact that the cuda12.0-pip devcontainer also includes llvm16, perhaps it would be worthwhile to revisit if llvm16 is required in either of the pip containers and limit this PR to unblocking the conda devcontainers?

That being said, if we know that llvm16 isn't required for the pip devcontainers, happy to repurpose this PR to just drop that everywhere; mind if I defer to you @bdice? Don't really have too much familiarity here 😅

[cwharris]

We want to keep llvm in the pip env containers. We want to drop it for conda. We'll get the relevant bits from conda as conda often requires we do so. Meanwhile pip is fine with system-wide deps in most cases. I think the changes look good as is.

[cwharris]

LGTM

[charlesbluca]

Forgot to follow up - can verify that the changes here unblocked the cuda11.8-conda devcontainer build on my end, so if things look good this should be safe to merge once tests are green 🙂

[bdice]

Thanks for the context @cwharris, I see why that makes sense to use system LLVM for pip devcontainers but wouldn’t have thought to do it otherwise.

[bdice]

/ok to test

[bdice]

/merge