-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy benchmarks for cuDF-python #14591
Remove legacy benchmarks for cuDF-python #14591
Conversation
/ok to test |
@shwina Are there any other steps I need to take to make this PR eligible for review? I see the "pr-builder" check has yet to complete. |
Thank you, @osidekyle -- no, it's looking great! After CI passes, I'll go ahead and merge. Thanks so much for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galipremsagar could you also take a quick look to ensure nothing was missed?
great! I am curious, I can't seem to find where this CI is running in the "Actions" tab or by just clicking on it here in the PR. Am I able to view the run somewhere? |
/ok to test |
Ah, when the PR submitter is not part of the rapidsai org, the CI checks need a team member to comment You can see the progress here: https://github.com/rapidsai/cudf/actions/runs/7145162927 |
Just FYI the failed C++ tests are due to a race condition bug being addressed in #14598. |
/ok to test |
/merge |
This PR removes the legacy benchmarks within the python/cudf/cudf/benchmarks directory and the "excludes" reference to these benchmarks in pyproject.toml. Closes rapidsai#14573. Authors: - Kyle Hawkins (https://github.com/osidekyle) - Ashwin Srinath (https://github.com/shwina) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: rapidsai#14591
Description
This PR removes the legacy benchmarks within the python/cudf/cudf/benchmarks directory and the "excludes" reference to these benchmarks in pyproject.toml. Closes #14573.
Checklist