Fix DataFrame.reindex when column reindexing to MultiIndex/RangeIndex #14605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
bug
mroeschke
changed the title
mroeschke
commented
Dec 12, 2023
| df = self | ||
| else: | ||
| columns = as_index(columns) | ||
| intersection = self._data.to_pandas_index().intersection( |
There was a problem hiding this comment.
Happy to have suggestion if there's a way to do this without dispatching to pandas. This was to ensure the MultiIndex intersection case worked correctly
galipremsagar
approved these changes
Dec 13, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reindex(columns=cudf.MultiIndex)will raise sinceset(cudf.MultiIndex)is being calledreindex(columns=range/RangeIndex)would not necessarily retain a RangeIndex resultDiscovered during refactoring
DataFrame.__init__and further convinces me that thecolumnshould be passed toColumnAccessoreventuallyChecklist