-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write file-level statistics when writing ORC files with zero rows #14707
Merged
rapids-bot
merged 17 commits into
rapidsai:branch-24.02
from
vuule:bug-write_orc-empty-file-stats
Jan 8, 2024
Merged
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ac011cd
skip stuff more based on stats freq
vuule 088df4b
almost works
vuule 395ebac
works
vuule b1a622b
keep column types even without rows
vuule b95a6f6
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule 6ac3cb2
fix doc
vuule 49d9e3b
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule 7bc99e5
stylin
vuule cbdc644
add has nulls to root column
vuule a95860c
rename
vuule c0cf082
catch all
vuule e02f0fc
Merge branch 'bug-write_orc-empty-file-stats' of https://github.com/v…
vuule 27e74a5
Merge branch 'branch-24.02' of https://github.com/rapidsai/cudf into …
vuule d8bf3ac
remove debug code
vuule 2b0bc33
expand/fix comment
vuule 04b83f9
expand comment
vuule a90de42
Merge branch 'branch-24.02' into bug-write_orc-empty-file-stats
vuule File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of a better name for this function. I fear the name implies that it's the
close()
that's skipped.skip_footer_write_on_close()
is too long.If we can't think of a succinct name, maybe we should keep
skip_close()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg, my updated code for this function got lost between commits.
I think
skip_close
is a pretty accurate name, given that we raise the_closed
flag inskip_close
andclose()
returns immediately if that flag is raised.I'll update the docs above, sorry for the confusion.