Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some frame.py typing, move seldom used methods in frame.py #14766

Merged
merged 13 commits into from
Jan 19, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  • _drop_na_columns was only use on IndexedFrame and not Frame so moved the method to `IndexedFrame
  • _has_nulls is equivalent to isna().any()
  • Some typing

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 16, 2024
@mroeschke mroeschke requested a review from a team as a code owner January 16, 2024 23:19
@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

@mroeschke there's a real issue here that's popping up in the Cython code.

@vyasr
Copy link
Contributor

vyasr commented Jan 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit 1c37c78 into rapidsai:branch-24.02 Jan 19, 2024
66 of 67 checks passed
@mroeschke mroeschke deleted the ref/frame/cleanups branch January 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants