Use offsetalator in cudf::strings::copy_slice #14844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
davidwendt
added
3 - Ready for Review
bdice
reviewed
Jan 26, 2024
| input_offsets, | ||
| input_offsets + offsets_column->size(), | ||
| d_offsets, | ||
| cuda::proclaim_return_type<int64_t>( |
There was a problem hiding this comment.
Do you think we should declare something like size_type that would be a proper type name for all the int64_ts that are being sprinkled around? It's pretty subtle in some cases, like the 0L literal written above. I would want to reduce the possibility of unwanted casting (like forgetting to write 0L instead of 0) by having a type name with clear intent.
There was a problem hiding this comment.
I do not wish to create a special type at this time and prefer not to obfuscate int64_t in this code.
bdice
changed the title
bdice
approved these changes
Jan 26, 2024
bdice
changed the title
davidwendt
changed the title
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded offset types with offsetalator in
cudf::strings::detail::copy_slice.Checklist