Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thrust::tuple with cuda::std::tuple #15089

Closed
wants to merge 3 commits into from

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Feb 20, 2024

We want to move away from thrust types in API boundaries in favor of the more suited cuda::std types

We want to move away from thrust types in API boundaries in favor of the more suited `cuda::std` types
@miscco miscco requested a review from a team as a code owner February 20, 2024 14:25
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Feb 20, 2024
@PointKernel PointKernel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 20, 2024
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

The check-style CI failures can be fixed by following the formatting guidance.

The PR should be ready to merge once the style check passes and the headers are properly regrouped.

cpp/benchmarks/common/generate_input.cu Outdated Show resolved Hide resolved
@miscco
Copy link
Contributor Author

miscco commented Feb 20, 2024

Hm I tried the pre-commit inside the cuda12-pip container Will see whether another container works better

@PointKernel
Copy link
Member

Hm I tried the pre-commit inside the cuda12-pip container Will see whether another container works better

Weird. That should work. Maybe try to format manually:

pre-commit run --all-files

@bdice
Copy link
Contributor

bdice commented Feb 21, 2024

@miscco I pushed a change resulting from pre-commit run --all-files and merged the upstream. However, it seems like devcontainer builds are not passing. Maybe look at those build logs and see what's going wrong.

@miscco
Copy link
Contributor Author

miscco commented Feb 21, 2024

@bdice we do replace thrust::tuple with cuda::std::tuple in 2.3.x and add some interop. Until then this wont work because the fancy iterators internally use thrust::tuple

Will close the PR for now.

@miscco miscco closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants