Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse newline as whitespace character while tokenizing JSONL inputs with non-newline delimiter #16950

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Parse newline as whitespace character while tokenizing JSONL inputs with non-newline delimiter #16950

merged 2 commits into from
Sep 30, 2024

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Sep 27, 2024 •
edited by raydouglass
Loading

Backporting PR #16923: : Parse newline as whitespace character while tokenizing JSONL inputs

Addresses #16915

Authors:

Approvers:

URL: #16923

Description

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@shrshi
Parse newline as whitespace character while tokenizing JSONL inputs w…
114f3c6 
…ith non-newline delimiter (rapidsai#16923)

Addresses rapidsai#16915

Authors:
  - Shruti Shivakumar (https://github.com/shrshi)

Approvers:
  - Basit Ayantunde (https://github.com/lamarrr)
  - Karthikeyan (https://github.com/karthikeyann)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: rapidsai#16923
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 27, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 27, 2024
@shrshi shrshi marked this pull request as ready for review September 27, 2024 21:59
@shrshi shrshi requested a review from a team as a code owner September 27, 2024 21:59
@shrshi shrshi requested review from ttnghia, PointKernel, bdice and vyasr and removed request for a team September 27, 2024 21:59
@shrshi shrshi added ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround cuIO cuIO issue labels Sep 27, 2024
@karthikeyann
Copy link
Contributor

/ok to test

PointKernel
PointKernel approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking nit

cpp/src/io/json/nested_json_gpu.cu Outdated Show resolved Hide resolved
@ttnghia ttnghia changed the title Parse newline as whitespace character while tokenizing JSONL inputs w… Parse newline as whitespace character while tokenizing JSONL inputs with non-newline delimiter Sep 28, 2024
@shrshi
Copy link
Contributor Author

shrshi commented Sep 28, 2024

/ok to test

@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Sep 30, 2024
@raydouglass raydouglass merged commit f20491d into rapidsai:branch-24.10 Sep 30, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@ttnghia ttnghia ttnghia approved these changes

@PointKernel PointKernel PointKernel approved these changes

@bdice bdice Awaiting requested review from bdice

@vyasr vyasr Awaiting requested review from vyasr

Assignees
No one assigned
Labels
! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shrshi @karthikeyann @ttnghia @PointKernel @raydouglass