-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add __setitem__() #2442
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kkraus14
added
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Python) Reviewer
and removed
2 - In Progress
Currently a work in progress
labels
Aug 12, 2019
kkraus14
reviewed
Aug 12, 2019
kkraus14
reviewed
Aug 12, 2019
kkraus14
reviewed
Aug 12, 2019
kkraus14
reviewed
Aug 12, 2019
kkraus14
reviewed
Aug 12, 2019
kkraus14
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, had a few minor comments, but they can be dealt with in followups
kkraus14
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Python) Reviewer
labels
Aug 12, 2019
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Oct 11, 2022
To mimic pandas, we must upcast a column to the numpy result_type of the column itself and the input value dtype. This previously occurred in all relevant cases except when the index provided to __setitem__ was a single integer (originally introduced in rapidsai#2442). Closes rapidsai#11901.
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 4, 2022
To mimic pandas, we must upcast a column to the numpy result_type of the column itself and the input value dtype. This previously occurred in all relevant cases except when the index provided to __setitem__ was a single integer (originally introduced in #2442). Closes #11901. Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - GALI PREM SAGAR (https://github.com/galipremsagar) - Bradley Dice (https://github.com/bdice) URL: #11904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1468
Enables setting values of a Series by position or label via
s[key] = value
,s.iloc[key] = value
ands.loc[key] = value
.key
can be:cudf::copy_range
)cudf::scatter
)cudf::scatter
)Adds
Series.at
andSeries.iat
as aliases forSeries.loc
andSeries.iloc
.Also enables
df.iloc[key] = value
anddf.loc[key] = value
for DataFrames.Not supported:
df.loc
for dataframes with a MultiIndex