Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict CuPy to 6 #3539

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Restrict CuPy to 6 #3539

merged 2 commits into from
Dec 5, 2019

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Dec 5, 2019

As we have not yet tested CuPy 7, restrict cuDF usage to CuPy 6 for now.

As we have not yet tested CuPy 7, restrict cuDF usage with CuPy to 6 for
now.
@jakirkham jakirkham requested a review from a team December 5, 2019 17:54
@jakirkham
Copy link
Member Author

cc @kkraus14 @rlratzel

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge conda Python Affects Python cuDF API. labels Dec 5, 2019
@beckernick
Copy link
Member

This will only be enforced at the time of cuDF installation, correct? I.e., is it correct that I could still install CuPy 7 afterwards if need be?

@kkraus14
Copy link
Collaborator

kkraus14 commented Dec 5, 2019

This will only be enforced at the time of cuDF installation, correct? I.e., is it correct that I could still install CuPy 7 afterwards if need be?

It will act as a constraint if you conda install in general. I believe it's possible to override the constraint though.

@jakirkham
Copy link
Member Author

This will only be enforced at the time of cuDF installation, correct? I.e., is it correct that I could still install CuPy 7 afterwards if need be?

It would need to be forced, but yeah you could override.

@beckernick
Copy link
Member

That's fine with me 👍

@jakirkham
Copy link
Member Author

Thanks Ray! 😄

@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #3539 into branch-0.11 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.11    #3539   +/-   ##
============================================
  Coverage        87.38%   87.38%           
============================================
  Files               49       49           
  Lines             9376     9376           
============================================
  Hits              8193     8193           
  Misses            1183     1183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adbcc52...ef2b9f0. Read the comment docs.

@jakirkham
Copy link
Member Author

Looks like this is ready to merge. 🙂

@harrism harrism merged commit a21688b into rapidsai:branch-0.11 Dec 5, 2019
@jakirkham jakirkham deleted the use_cupy_6 branch December 6, 2019 00:28
@jakirkham
Copy link
Member Author

Thanks @harrism! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants