Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove duplicate definitions from docs #5069

Merged
merged 23 commits into from
May 19, 2020

Conversation

devavret
Copy link
Contributor

@devavret devavret commented Apr 30, 2020

Uses @copydoc to remove duplicate definitions from detail headers.
Depends on #5049
Also Closes #4528

@devavret devavret requested a review from a team as a code owner April 30, 2020 23:41
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@devavret devavret added 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels May 15, 2020
@devavret devavret changed the title [WIP] Remove duplicate definitions from docs [REVIEW] Remove duplicate definitions from docs May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.14@8bdcba3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.14    #5069   +/-   ##
==============================================
  Coverage               ?   88.38%           
==============================================
  Files                  ?       55           
  Lines                  ?    10489           
  Branches               ?        0           
==============================================
  Hits                   ?     9271           
  Misses                 ?     1218           
  Partials               ?        0           
Impacted Files Coverage Δ
python/cudf/cudf/_lib/legacy/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 86.52% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 89.51% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.73% <0.00%> (ø)
python/cudf/cudf/utils/docutils.py 100.00% <0.00%> (ø)
python/cudf/cudf/datasets.py 96.55% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 95.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 89.70% <0.00%> (ø)
python/dask_cudf/dask_cudf/sorting.py 94.11% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_s3.py 95.65% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdcba3...e8c3552. Read the comment docs.

Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor spelling, indenting requests.

cpp/include/cudf/unary.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/unary.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/unary.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/unary.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/binaryop.hpp Outdated Show resolved Hide resolved
devavret and others added 2 commits May 19, 2020 05:19
Co-authored-by: David <45795991+davidwendt@users.noreply.github.com>
@devavret devavret requested a review from davidwendt May 18, 2020 23:58
@harrism
Copy link
Member

harrism commented May 19, 2020

rerun tests

@devavret devavret merged commit 6e20f15 into rapidsai:branch-0.14 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Detail gather's documentation is wrong
4 participants