Fix reference count on Java DeviceMemoryBuffer after contiguousSplit [skip ci] #5915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5815 columns created from a contiguous table are not incrementing the refcount of the underlying device memory buffer. That means columns are no longer being "sliced" from the buffer such that they are able to hold the buffer open after the buffer closes. The RAPIDS Accelerator for Apache Spark relies upon this behavior.
This updates the
ColumnVector
constructor for a column built from a contiguous table to increment the reference count of the underlying buffer and add it to the list of items to close when the column is finally closed. To avoid having to explicitly slice the underlying buffer and create unnecessary object overhead, I exposed the reference counting as a method as has been done in other cudf Java classes.