Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference count on Java DeviceMemoryBuffer after contiguousSplit [skip ci] #5915

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 11, 2020

After #5815 columns created from a contiguous table are not incrementing the refcount of the underlying device memory buffer. That means columns are no longer being "sliced" from the buffer such that they are able to hold the buffer open after the buffer closes. The RAPIDS Accelerator for Apache Spark relies upon this behavior.

This updates the ColumnVector constructor for a column built from a contiguous table to increment the reference count of the underlying buffer and add it to the list of items to close when the column is finally closed. To avoid having to explicitly slice the underlying buffer and create unnecessary object overhead, I exposed the reference counting as a method as has been done in other cudf Java classes.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer labels Aug 11, 2020
@jlowe jlowe requested a review from a team as a code owner August 11, 2020 02:09
@jlowe jlowe self-assigned this Aug 11, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

Copy link
Contributor

@kuhushukla kuhushukla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this Jason. Fix looks good to me.

@revans2 revans2 merged commit 1f6eb0a into rapidsai:branch-0.15 Aug 11, 2020
@jlowe jlowe deleted the jni-contigsplit-refcount branch September 10, 2021 15:46
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond Java Affects Java cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants