[REVIEW] Small fixes and improvements to java Arrow IPC [skip-ci] #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
jlowe
reviewed
Sep 3, 2020
|
@jlowe I think I have addressed your review comments could you take another look? |
jlowe
approved these changes
Sep 3, 2020
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a number of different things around the arrow IPC format for java.
It fixes a bug where we could not read more than a 10MB buffer.
It adds in a few more APIs to be able to better batch reading and writing data.
It provides callbacks to let you know when it needs the GPU and when it no longer needs the GPU to better deal with concurreny.