Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add support for LEAD/LAG window functions for fixed-width types [redux] #6277

Merged
merged 18 commits into from
Oct 7, 2020
Merged

[REVIEW] Add support for LEAD/LAG window functions for fixed-width types [redux] #6277

merged 18 commits into from
Oct 7, 2020

Commits on Sep 20, 2020

  1. [lead/lag] [redux] Implement LEAD/LAG window functions 

    Initial implementation for LEAD/LAG window functions,
for fixed-width types.

This version is implemented within grouped_rolling_window().
    @mythrocks
    mythrocks committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    a56a106 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1e24085 View commit details
    Browse the repository at this point in the history

  2. [lead/lag] [redux] Added all-nulls test.

    @mythrocks
    mythrocks committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    c6245c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    5410189 View commit details
    Browse the repository at this point in the history

  2. [lead/lag] [redux] Fixed headers in test.

    @mythrocks
    mythrocks committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    af98ce9 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. [lead/lag] [redux] Review changes: 

    1. Fixed includes
2. Un-templatized DeviceLeadLag
3. Documentation fixes
    @mythrocks
    mythrocks committed Sep 24, 2020
    Configuration menu
    Copy the full SHA
    ccd5c40 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    8bcb349 View commit details
    Browse the repository at this point in the history

  2. [lead/lag] [redux] Modified tests, from review. 

    1. Added test with default column with null values.
2. Variables for window bounds.
    @mythrocks
    mythrocks committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    27c510d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    0e80f6e View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. [lead/lag] Added short-ckt path for LEAD/LAG(0)

    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    f9cc799 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    76d58d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. [lead/lag] Cleanup from review: 

    1. Moved Lead/Lag specific error checks out of rolling_window()
2. Moved Lead/Lag specific short-circuit evaluation out of rolling_window()
3. Added tests for error-checking
    @mythrocks
    mythrocks committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    1cd338f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    80244e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. [lead/lag] Code formatting.

    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    e266052 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    b16ce5f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Merge remote-tracking branch 'origin/branch-0.16' into lead-lag-branc… 

    …h-0.16-redux
    @mythrocks
    mythrocks committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    20f1e78 View commit details
    Browse the repository at this point in the history

  2. [lead/lag] Review changes: 

    1. Remove redundant checks for LEAD/LAG in non-LEAD/LAG SFINAE path
2. Remove hardcode for stream id
    @mythrocks
    mythrocks committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    1a90b13 View commit details
    Browse the repository at this point in the history

  3. [lead/lag] Code formatting.

    @mythrocks
    mythrocks committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    afe0ea7 View commit details
    Browse the repository at this point in the history