-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Support nullable timestamp columns in time range window functions #6557
[REVIEW] Support nullable timestamp columns in time range window functions #6557
Commits on Oct 19, 2020
-
Fix time range window queries with null timestamps:
1. Initial commit. Fix for non-grouped time-ranges with null timestamps, in ASC order. 2. Fixed non-grouped time-ranges with null timestampw, in DESC. 3. Fixed grouped time-ranges with null timestamp, in ASC. 4. Fixed grouped time-ranges with null timestamp, in DESC. 5. Fixed grouped time-ranges for ASC (following) 6. Tests for different combinations of timestamp null grouping, timestamp ordering, and key grouping. 7. Refactor: Common code gathered to utility function. 8. Code formatting
Configuration menu - View commit details
-
Copy full SHA for 5502ce2 - Browse repository at this point
Copy the full SHA 5502ce2View commit details -
Fix time range window queries with null timestamps
Added to CHANGELOG.md.
Configuration menu - View commit details
-
Copy full SHA for 72f20f3 - Browse repository at this point
Copy the full SHA 72f20f3View commit details -
Merge remote-tracking branch 'origin/branch-0.17' into null-checks-ti…
…mestamp-branch-0.17
Configuration menu - View commit details
-
Copy full SHA for 07ab590 - Browse repository at this point
Copy the full SHA 07ab590View commit details
Commits on Oct 22, 2020
-
Merge remote-tracking branch 'origin/branch-0.17' into null-checks-ti…
…mestamp-branch-0.17
Configuration menu - View commit details
-
Copy full SHA for 261454f - Browse repository at this point
Copy the full SHA 261454fView commit details -
Fix time range window queries with null timestamps
1. Non-groupby case: Use null-count to calculate null bounds 2. Groupby case: Use partition_point()
Configuration menu - View commit details
-
Copy full SHA for 25aac84 - Browse repository at this point
Copy the full SHA 25aac84View commit details
Commits on Oct 23, 2020
-
Fix time range window queries with null timestamps
1. Short circuit eval for all-null/no-null cases. 2. Test cases for all-null/no-null. 3. Code formatting
Configuration menu - View commit details
-
Copy full SHA for 7f5a235 - Browse repository at this point
Copy the full SHA 7f5a235View commit details -
Merge remote-tracking branch 'origin/branch-0.17' into null-checks-ti…
…mestamp-branch-0.17
Configuration menu - View commit details
-
Copy full SHA for 5aeeeb1 - Browse repository at this point
Copy the full SHA 5aeeeb1View commit details
Commits on Oct 25, 2020
-
Merge remote-tracking branch 'origin/branch-0.17' into null-checks-ti…
…mestamp-branch-0.17
Configuration menu - View commit details
-
Copy full SHA for 58e3426 - Browse repository at this point
Copy the full SHA 58e3426View commit details
Commits on Oct 26, 2020
-
Fix time range window queries with null timestamps
1. Fixed angle-brackets for header inclusion. 2. Switched to doxygen-style function documentation
Configuration menu - View commit details
-
Copy full SHA for d93fb8f - Browse repository at this point
Copy the full SHA d93fb8fView commit details -
Merge remote-tracking branch 'origin/branch-0.17' into null-checks-ti…
…mestamp-branch-0.17
Configuration menu - View commit details
-
Copy full SHA for 7415241 - Browse repository at this point
Copy the full SHA 7415241View commit details -
Fix time range window queries with null timestamps
3. Code formatting
Configuration menu - View commit details
-
Copy full SHA for f8b3ec5 - Browse repository at this point
Copy the full SHA f8b3ec5View commit details -
Fix time range window queries with null timestamps
1. Streamline null_bound calculation, with fewer comparisons.
Configuration menu - View commit details
-
Copy full SHA for 9b97c78 - Browse repository at this point
Copy the full SHA 9b97c78View commit details -
Fix time range window queries with null timestamps
2. Fix botched null_bound calculation cleanup. 3. Remove errant println in tests.
Configuration menu - View commit details
-
Copy full SHA for 5d82e7c - Browse repository at this point
Copy the full SHA 5d82e7cView commit details