Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Support nullable timestamp columns in time range window functions #6557

Merged

Commits on Oct 19, 2020

  1. Fix time range window queries with null timestamps:

    1. Initial commit. Fix for non-grouped time-ranges with
       null timestamps, in ASC order.
    2. Fixed non-grouped time-ranges with null timestampw, in DESC.
    3. Fixed grouped time-ranges with null timestamp, in ASC.
    4. Fixed grouped time-ranges with null timestamp, in DESC.
    5. Fixed grouped time-ranges for ASC (following)
    6. Tests for different combinations of timestamp null grouping,
       timestamp ordering, and key grouping.
    7. Refactor: Common code gathered to utility function.
    8. Code formatting
    mythrocks committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    5502ce2 View commit details
    Browse the repository at this point in the history
  2. Fix time range window queries with null timestamps

    Added to CHANGELOG.md.
    mythrocks committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    72f20f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07ab590 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Configuration menu
    Copy the full SHA
    261454f View commit details
    Browse the repository at this point in the history
  2. Fix time range window queries with null timestamps

    1. Non-groupby case: Use null-count to calculate null bounds
    2. Groupby case: Use partition_point()
    mythrocks committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    25aac84 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Fix time range window queries with null timestamps

    1. Short circuit eval for all-null/no-null cases.
    2. Test cases for all-null/no-null.
    3. Code formatting
    mythrocks committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7f5a235 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5aeeeb1 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Configuration menu
    Copy the full SHA
    58e3426 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Fix time range window queries with null timestamps

    1. Fixed angle-brackets for header inclusion.
    2. Switched to doxygen-style function documentation
    mythrocks committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    d93fb8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7415241 View commit details
    Browse the repository at this point in the history
  3. Fix time range window queries with null timestamps

    3. Code formatting
    mythrocks committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    f8b3ec5 View commit details
    Browse the repository at this point in the history
  4. Fix time range window queries with null timestamps

    1. Streamline null_bound calculation, with fewer comparisons.
    mythrocks committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    9b97c78 View commit details
    Browse the repository at this point in the history
  5. Fix time range window queries with null timestamps

    2. Fix botched null_bound calculation cleanup.
    3. Remove errant println in tests.
    mythrocks committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5d82e7c View commit details
    Browse the repository at this point in the history