Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] support contiguous split of fixed-point decimal column #6762

Closed

Conversation

sperlingxx
Copy link
Contributor

This PR is about to support contiguous split of fixed-point decimal column through implementing specialized dispatching branches for fixed-point types.

@sperlingxx sperlingxx requested a review from a team as a code owner November 13, 2020 03:29
@sperlingxx sperlingxx changed the title [Review] support contiguous split of fixed-point decimal column [REVIEW] support contiguous split of fixed-point decimal column Nov 13, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #6762 (a983496) into branch-0.17 (158cb6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #6762   +/-   ##
============================================
  Coverage        81.77%   81.77%           
============================================
  Files               96       96           
  Lines            15885    15885           
============================================
  Hits             12990    12990           
  Misses            2895     2895           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158cb6b...a983496. Read the comment docs.

@revans2
Copy link
Contributor

revans2 commented Nov 13, 2020

@nvdbaranec could you take a look at this?

@nvdbaranec
Copy link
Contributor

nvdbaranec commented Nov 13, 2020

There is a huge rewrite of contiguous_split that will be merged soon (#6615) that will obliterate any changes that come from this PR. I suggest tabling this PR for now - I'll make sure decimal works with the new PR

Edit: Yes, the new PR (#6615) handles decimal as-is. I'll update the tests to reflect this.

Pinging @jrhemstad

@jlowe
Copy link
Member

jlowe commented Nov 19, 2020

Should this be closed as superceded by #6615?

@sperlingxx
Copy link
Contributor Author

Should this be closed as superceded by #6615?

Yes, I close it now.

@sperlingxx sperlingxx closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants