-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] support contiguous split of fixed-point decimal column #6762
Conversation
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
50828f9
to
4bc88dd
Compare
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #6762 +/- ##
============================================
Coverage 81.77% 81.77%
============================================
Files 96 96
Lines 15885 15885
============================================
Hits 12990 12990
Misses 2895 2895 Continue to review full report at Codecov.
|
@nvdbaranec could you take a look at this? |
There is a huge rewrite of contiguous_split that will be merged soon (#6615) that will obliterate any changes that come from this PR. I suggest tabling this PR for now - I'll make sure decimal works with the new PR Edit: Yes, the new PR (#6615) handles decimal as-is. I'll update the tests to reflect this. Pinging @jrhemstad |
8665825
to
a983496
Compare
Should this be closed as superceded by #6615? |
Yes, I close it now. |
This PR is about to support contiguous split of fixed-point decimal column through implementing specialized dispatching branches for fixed-point types.