Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support contains() on lists of primitives #7039

Merged
merged 34 commits into from
Jan 25, 2021
Merged

Support contains() on lists of primitives #7039

merged 34 commits into from
Jan 25, 2021

Commits on Dec 18, 2020

  1. Support contains() on lists of primitives

    @mythrocks
    mythrocks committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    dd01ba1 View commit details
    Browse the repository at this point in the history

  2. Support contains() on lists of primitives 

    Update CHANGELOG, + headers yaml
    @mythrocks
    mythrocks committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    4558261 View commit details
    Browse the repository at this point in the history

  3. Support contains() on lists of primitives 

    Review feedback:
  1. Optimized case where skey is null
  2. Rephrased nested ternary if.
    @mythrocks
    mythrocks committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a87ffb0 View commit details
    Browse the repository at this point in the history

  4. Support contains() on lists of primitives 

    Review:
  3. Construct mutable output view only if required.
    @mythrocks
    mythrocks committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    21aae8a View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2020

  1. Support contains() on lists of primitives: 

    Fix null-mask for non-null list rows containing
null elements.
    @mythrocks
    mythrocks committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    4e5b819 View commit details
    Browse the repository at this point in the history

  2. Support contains() on lists of primitives: 

    Further correction for null_mask
    @mythrocks
    mythrocks committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    752379a View commit details
    Browse the repository at this point in the history

  3. Support contains() on lists of primitives: 

    Further correction for null_mask
    @mythrocks
    mythrocks committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    551c014 View commit details
    Browse the repository at this point in the history

  4. Support contains() on lists of primitives: 

    Added support for skey columns (instead of just scalars).
    @mythrocks
    mythrocks committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    36ffde8 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    2e7d725 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    80510cf View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f9bb045 View commit details
    Browse the repository at this point in the history

  2. Support contains() on lists of primitives: 

    Review feedback.
    @mythrocks
    mythrocks committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    f880b46 View commit details
    Browse the repository at this point in the history

  3. Support contains() on lists of primitives 

    Code formatting after review feedback.
    @mythrocks
    mythrocks committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ce92cc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Support contains() on lists of primitives 

    1. Iterator-based detail function.
2. Iterator-based search loop.
3. Added pair iterators to list_device_view.
    @mythrocks
    mythrocks committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    9c92bf8 View commit details
    Browse the repository at this point in the history

  2. Support contains() on lists of primitives: 

    Renamed skey(s) to search_key(s)
    @mythrocks
    mythrocks committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    542e39a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Support contains() on lists of primitives 

    Common code for null mask construction.
    @mythrocks
    mythrocks committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    0a60a12 View commit details
    Browse the repository at this point in the history

  2. Chrono support in lists::contains()

    @mythrocks
    mythrocks committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    63d1a4a View commit details
    Browse the repository at this point in the history

  3. Added validity iterator for scalars.

    @mythrocks
    mythrocks committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    ed9269f View commit details
    Browse the repository at this point in the history

  4. Collapsed construct_null_mask() single function

    @mythrocks
    mythrocks committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2d469b7 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    a398bb6 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Collapsed contains() implementation to one impl function

    @mythrocks
    mythrocks committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    6ebed08 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Renamed search_key_has_all_nulls

    @mythrocks
    mythrocks committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    e01e860 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2021

  1. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    21d06e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Fixed behaviour for lists containing nulls: 

    contains() must return true if a list row contains the search key,
even if the row contains nulls.
If the list row does not contain the search key, and contains nulls,
it must return null.
    @mythrocks
    mythrocks committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    792bd86 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Cleaned up SFINAE is_supported().

    @mythrocks
    mythrocks committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    bb800a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Remove names for unused function/template parameters.

    @mythrocks
    mythrocks committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    1210f83 View commit details
    Browse the repository at this point in the history

  2. Code formatting.

    @mythrocks
    mythrocks committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    c77d1a1 View commit details
    Browse the repository at this point in the history

  3. Fixed documentation for make_validity_iterator(scalar)

    @mythrocks
    mythrocks committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    21bd39d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Added Doxygen directives.

    @mythrocks
    mythrocks committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    793863a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    b0ad781 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Move namespace directives to file level.

    @mythrocks
    mythrocks committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    4225a62 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/branch-0.18' into list-contains

    @mythrocks
    mythrocks committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    f7d4bad View commit details
    Browse the repository at this point in the history

  3. Fix doxygen_groups.h lists_contains group

    @mythrocks
    mythrocks committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    d6ddee0 View commit details
    Browse the repository at this point in the history

  4. Move tests to namespace. 

    Also, fix copyright year.
    @mythrocks
    mythrocks committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    b3b5b6c View commit details
    Browse the repository at this point in the history