Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JNI and Java bindings for list_contains [skip ci] #7125

Merged
merged 11 commits into from
Jan 27, 2021
Merged

Add JNI and Java bindings for list_contains [skip ci] #7125

merged 11 commits into from
Jan 27, 2021

Conversation

kuhushukla
Copy link
Contributor

Adds JNI and Java side bindings for list_contains that is being added as part of #7039.

@kuhushukla kuhushukla added the 2 - In Progress Currently a work in progress label Jan 12, 2021
@kuhushukla kuhushukla self-assigned this Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #7125 (a237e15) into branch-0.18 (8860baf) will increase coverage by 0.11%.
The diff coverage is 87.98%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #7125      +/-   ##
===============================================
+ Coverage        82.09%   82.20%   +0.11%     
===============================================
  Files               97       98       +1     
  Lines            16474    16692     +218     
===============================================
+ Hits             13524    13722     +198     
- Misses            2950     2970      +20
Impacted Files Coverage Δ
python/cudf/cudf/_lib/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/lists.py 91.66% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/cudautils.py 48.38% <ø> (-0.17%) ⬇️
python/cudf/cudf/utils/dtypes.py 89.18% <ø> (+0.08%) ⬆️
python/cudf/cudf/utils/ioutils.py 78.71% <ø> (ø)
python/dask_cudf/dask_cudf/core.py 74.26% <ø> (+0.25%) ⬆️
python/dask_cudf/dask_cudf/groupby.py 92.15% <ø> (-2.90%) ⬇️
python/dask_cudf/dask_cudf/io/tests/test_s3.py 95.94% <ø> (+0.11%) ⬆️
python/cudf/cudf/io/orc.py 86.89% <63.63%> (-1.51%) ⬇️
python/cudf/cudf/core/dataframe.py 90.49% <72.41%> (-0.22%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc40c52...7943a15. Read the comment docs.

@kuhushukla kuhushukla mentioned this pull request Jan 21, 2021
Merged
@kuhushukla kuhushukla added the Spark Functionality that helps Spark RAPIDS label Jan 26, 2021
@kuhushukla kuhushukla marked this pull request as ready for review January 26, 2021 16:09
@kuhushukla kuhushukla requested a review from a team as a code owner January 26, 2021 16:09
mythrocks
mythrocks reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Very minor nitpicks.

java/src/main/java/ai/rapids/cudf/ColumnView.java Show resolved Hide resolved
java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java Outdated Show resolved Hide resolved
@kuhushukla
Copy link
Contributor Author

@revans2 @mythrocks please take a look. Thanks!

revans2
revans2 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just a few nits.

java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
java/src/main/java/ai/rapids/cudf/ColumnView.java Outdated Show resolved Hide resolved
@revans2 revans2 changed the title Add JNI and Java bindings for list_contains Add JNI and Java bindings for list_contains [skip ci] Jan 26, 2021
@revans2 revans2 added Java Affects Java cuDF API. feature request New feature or request non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels Jan 26, 2021
mythrocks
mythrocks approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kuhushukla kuhushukla added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 27, 2021
@revans2 revans2 removed the 2 - In Progress Currently a work in progress label Jan 27, 2021
@revans2
Copy link
Contributor

revans2 commented Jan 27, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dd1efe1 into rapidsai:branch-0.18 Jan 27, 2021
@kuhushukla kuhushukla mentioned this pull request Jan 28, 2021
Merged
rapids-bot bot pushed a commit that referenced this pull request Jan 28, 2021
Fix test column vector leak (#7238)
ab34580 
#7125 added a test column vector leak. This PR fixes this minor leak.

Authors:
  - Kuhu Shukla (@kuhushukla)

Approvers:
  - Jason Lowe (@jlowe)
  - Thomas Graves (@tgravescs)

URL: #7238
@mythrocks mythrocks mentioned this pull request Jan 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@mythrocks mythrocks mythrocks approved these changes

Assignees

@kuhushukla kuhushukla

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuhushukla @revans2 @mythrocks