-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for cudf::strings::to_lower #7316
Add gbenchmark for cudf::strings::to_lower #7316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, couple small things
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7316 +/- ##
==============================================
Coverage ? 82.22%
==============================================
Files ? 100
Lines ? 16969
Branches ? 0
==============================================
Hits ? 13953
Misses ? 3016
Partials ? 0 Continue to review full report at Codecov.
|
rerun tests |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake approval
@gpucibot merge |
Reference #5698
This creates a gbenchmark for the
cudf::strings::to_lower
. The device logic is the same forcudf::strings::to_upper
andcudf::strings::swapcase
so this a good measure for the 3 APIs.This PR is dependent on changes in PR #7292
These are mostly in the
generate_benchmark_input.cpp
The initial results were as follows:
The
convert_case
code here is a bit old. I changed it to use the more efficientmake_strings_children
utility and found the performance improved by 2xSo these changes are also included in this PR.