Change block size parameter from a global to a template param. #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbaranec
added
3 - Ready for Review
nvdbaranec
added
the
improvement
davidwendt
approved these changes
Feb 5, 2021
jrhemstad
approved these changes
Feb 5, 2021
nvdbaranec
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7333 +/- ##
==============================================
Coverage ? 81.80%
==============================================
Files ? 100
Lines ? 16608
Branches ? 0
==============================================
Hits ? 13586
Misses ? 3022
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses followup review comment: #7096 (comment)
There was a constexpr global being used to initialize a template that could have been supplied from it's own template value.