Refactor strings column factories #7397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrism
added
feature request
…n factories to use them
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7397 +/- ##
===============================================
+ Coverage 81.80% 82.26% +0.45%
===============================================
Files 101 101
Lines 16695 17244 +549
===============================================
+ Hits 13658 14185 +527
- Misses 3037 3059 +22
Continue to review full report at Codecov.
|
cwharris
requested changes
Mar 2, 2021
| 0, | ||
| stream); | ||
| auto repl = make_strings_column(cudf::detail::make_device_uvector_async(repl_chars, stream), | ||
| cudf::detail::make_device_uvector_async(repl_offsets, stream), |
There was a problem hiding this comment.
Since _chars and _offsets are always the same, can we move them to a broader scope to avoid needing stream synchronization?
davidwendt
requested changes
Mar 2, 2021
|
@cwharris what changes are you requesting? |
jrhemstad
approved these changes
Mar 3, 2021
davidwendt
reviewed
Mar 3, 2021
davidwendt
reviewed
Mar 3, 2021
davidwendt
requested changes
Mar 3, 2021
Thanks. Done. |
davidwendt
approved these changes
Mar 3, 2021
|
rerun tests |
cwharris
approved these changes
Mar 3, 2021
|
@harrism you addressed my concerns. 👍 |
|
@gpucibot merge |
harrism
added
5 - Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors strings column factories to eliminate the use of
device_vectorandstd::vectorparameters, and to facility more use ofdevice_uvectorin calls to the factories. This is a small part of #7287 . Multiple versions ofmake_strings_columnstakedevice_vectorparameters. This PR expands the use of iterator anddevice_spanversions to enable switching todevice_uvectoras described in #7287. It also adds newmake_device_uvector_async/syncutility functions.This will help facilitate safe CUDA stream usage.