Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Series/Dataframe Mixed Arithmetic #7491

Merged
merged 15 commits into from
Mar 18, 2021
Merged

Fix Series/Dataframe Mixed Arithmetic #7491

merged 15 commits into from
Mar 18, 2021

Conversation

brandon-b-miller
Copy link
Contributor

Fixes #7385

@brandon-b-miller brandon-b-miller added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels Mar 2, 2021
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner March 2, 2021 22:50
@brandon-b-miller brandon-b-miller added the bug Something isn't working label Mar 2, 2021
@brandon-b-miller brandon-b-miller mentioned this pull request Mar 9, 2021
Merged
@brandon-b-miller brandon-b-miller added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Mar 16, 2021
@codecov
Copy link

codecov bot commented Mar 16, 2021 •
edited
Loading

Codecov Report

Merging #7491 (b989d1e) into branch-0.19 (7871e7a) will increase coverage by 0.56%.
The diff coverage is 93.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7491      +/-   ##
===============================================
+ Coverage        81.86%   82.43%   +0.56%     
===============================================
  Files              101      101              
  Lines            16884    17350     +466     
===============================================
+ Hits             13822    14302     +480     
+ Misses            3062     3048      -14
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 93.34% <ø> (+0.48%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <87.50%> (-0.20%) ⬇️
python/cudf/cudf/core/frame.py 89.09% <89.47%> (+0.08%) ⬆️
python/cudf/cudf/core/column/column.py 87.86% <90.00%> (+0.10%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <90.32%> (-2.12%) ⬇️
python/cudf/cudf/core/series.py 91.65% <95.83%> (+0.86%) ⬆️
python/cudf/cudf/core/dataframe.py 90.88% <96.00%> (+0.41%) ⬆️
python/cudf/cudf/core/column/categorical.py 91.97% <100.00%> (+0.58%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.63% <100.00%> (+0.54%) ⬆️
python/cudf/cudf/core/column/string.py 86.76% <100.00%> (+0.26%) ⬆️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561f68a...b989d1e. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

rerun tests

@brandon-b-miller brandon-b-miller added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 18, 2021
@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 168c489 into rapidsai:branch-0.19 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@isVoid isVoid isVoid approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Comparison between Series and DataFrame fails when LHS is a Series
3 participants
@brandon-b-miller @galipremsagar @isVoid