Java support of casting string from/to decimal [skip ci] #7623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sperlingxx
changed the title
sperlingxx
added
4 - Needs cuDF (Java) Reviewer
5 - Ready to Merge
sperlingxx
changed the title
revans2
approved these changes
Mar 17, 2021
|
|
||
| /** | ||
| * Helper function to create decimal strings which can be processed by castStringToDecimal functor. | ||
| * We can not simply create decimal string via `String.valueOf`, because castStringToDecimal doesn't |
There was a problem hiding this comment.
Could you please file a follow on issue for this?
There was a problem hiding this comment.
I've filed issue for scientific notation. And appended the issue link here.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7623 +/- ##
===============================================
+ Coverage 81.86% 82.41% +0.54%
===============================================
Files 101 101
Lines 16884 17353 +469
===============================================
+ Hits 13822 14301 +479
+ Misses 3062 3052 -10
Continue to review full report at Codecov.
|
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provided Java side support of casting string from/to decimal, which is required by spark-rapids.
Although parsing of string formatted as scientific notation to decimal has not been supported yet by cuDF, we are able to implement string to decimal conversion at spark-rapids side through a two-steps hack:
In addition, this pull request also addressed issue #6795.