Fix ORC reader for empty DataFrame/Table #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgsl888prabhu
added
bug
github-actions
bot
added
Python
rgsl888prabhu
requested review from
vuule,
nvdbaranec and
devavret
and removed request for
trxcllnt and
jrhemstad
devavret
approved these changes
Mar 17, 2021
vuule
requested changes
Mar 17, 2021
nvdbaranec
approved these changes
Mar 17, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7624 +/- ##
===============================================
+ Coverage 81.86% 82.49% +0.62%
===============================================
Files 101 101
Lines 16884 17400 +516
===============================================
+ Hits 13822 14354 +532
+ Misses 3062 3046 -16
Continue to review full report at Codecov.
|
devavret
approved these changes
Mar 18, 2021
vuule
approved these changes
Mar 19, 2021
|
@gpucibot merge |
…rc_empty_dataframe
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ff.typesby default will have a main type as struct under which all other columns will originate. So, we need to skip first which is not a column and start with 1st index.(Look for
Type Informationin ORC Specification)Along with that, we should also take care of the scenario where user would specify specific column name to retrieve, but it doesn't exist in case of empty data frame/table.
Added test case to validate both scenario.
closes #7356