Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gbenchmark for converting strings to/from timestamps #7641

Merged

Conversation

davidwendt
Copy link
Contributor

Reference #5698
This creates a gbenchmark for cudf::strings::to_timestamps() and cudf::strings::from_timestamps() functions.
The benchmarks measures converting to/from a fixed format for days, seconds, ms, us, and ns.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 18, 2021
@davidwendt davidwendt self-assigned this Mar 18, 2021
@davidwendt davidwendt requested review from a team as code owners March 18, 2021 20:25
@github-actions github-actions bot added the CMake CMake build issue label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #7641 (a97c7bf) into branch-0.19 (7871e7a) will increase coverage by 0.22%.
The diff coverage is n/a.

❗ Current head a97c7bf differs from pull request most recent head 3b0bd35. Consider uploading reports for the commit 3b0bd35 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7641      +/-   ##
===============================================
+ Coverage        81.86%   82.08%   +0.22%     
===============================================
  Files              101      101              
  Lines            16884    17036     +152     
===============================================
+ Hits             13822    13984     +162     
+ Misses            3062     3052      -10     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/categorical.py 91.62% <ø> (+0.23%) ⬆️
python/cudf/cudf/core/column/column.py 87.77% <ø> (+0.01%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.09% <ø> (ø)
python/cudf/cudf/core/column/decimal.py 92.75% <ø> (-2.12%) ⬇️
python/cudf/cudf/core/column/lists.py 91.81% <ø> (+0.42%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <ø> (-0.20%) ⬇️
python/cudf/cudf/core/column/string.py 86.58% <ø> (+0.08%) ⬆️
python/cudf/cudf/core/column/timedelta.py 88.23% <ø> (ø)
python/cudf/cudf/core/column_accessor.py 95.28% <ø> (-0.03%) ⬇️
python/cudf/cudf/core/dataframe.py 90.79% <ø> (+0.32%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8773a40...3b0bd35. Read the comment docs.

Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, recommend 1 small change

cpp/benchmarks/string/convert_datetime_benchmark.cpp Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c21bd0e into rapidsai:branch-0.19 Mar 22, 2021
@davidwendt davidwendt deleted the benchmark-strings-datetime branch March 22, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants