-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gbenchmark for converting strings to/from timestamps #7641
Add gbenchmark for converting strings to/from timestamps #7641
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7641 +/- ##
===============================================
+ Coverage 81.86% 82.08% +0.22%
===============================================
Files 101 101
Lines 16884 17036 +152
===============================================
+ Hits 13822 13984 +162
+ Misses 3062 3052 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, recommend 1 small change
@gpucibot merge |
Reference #5698
This creates a gbenchmark for
cudf::strings::to_timestamps()
andcudf::strings::from_timestamps()
functions.The benchmarks measures converting to/from a fixed format for days, seconds, ms, us, and ns.