Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example to build custom application and link to libcudf #7671
Example to build custom application and link to libcudf #7671
Changes from 10 commits
c128957
fa688f1
7ef5fe0
abf20ab
43ebd65
eed062d
22d8bcb
a9a3bb5
d3b789c
d956daa
9957a7f
6f0b9ce
8f6a98e
b2fdb37
5ebf755
736e440
9494537
78e1d7c
efd897d
8a49e83
906154c
b80a7de
de82e6e
079b88e
feb77cc
6418342
7d5f8c2
d799c01
972f1a1
a87475e
66dd82c
145a96e
41a6e3f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this, but getting compile error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Min-repro: https://godbolt.org/z/d6Pqb34ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cudf/cpp/tests/groupby/groupby_test_util.hpp
Lines 73 to 74 in 500f42c
Perhaps like this then:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are extra two lines below the test example that are also relevant in creating an aggregation. For it's complexity, I created a separate function
make_single_aggregation_request
to wrap the logic.An offline discussion mentions all these complexity maybe alleviated once the vectors are replaced with
host_span
. And that APIs likeaggregation_request
shouldn't be owner to anaggregation
.