Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add copy methods in Java memory buffer [skip ci] #7791

Merged
merged 4 commits into from
Mar 31, 2021
Merged

add copy methods in Java memory buffer [skip ci] #7791

merged 4 commits into from
Mar 31, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Mar 31, 2021

This should simplify the code in the rapids shuffle manager (see NVIDIA/spark-rapids#2050).

@jlowe @abellina @revans2

@rongou rongou requested a review from a team as a code owner March 31, 2021 17:34
@github-actions github-actions bot added the Java Affects Java cuDF API. label Mar 31, 2021
@rongou rongou added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS labels Mar 31, 2021
@rongou rongou changed the title add copy methods in java memory buffer add copy methods in java memory buffer [skip ci] Mar 31, 2021
@rongou rongou mentioned this pull request Mar 31, 2021
Merged
jlowe
jlowe reviewed Mar 31, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

@rongou
Copy link
Contributor Author

rongou commented Mar 31, 2021

Good catch. :) Added tests.

@jlowe jlowe changed the title add copy methods in java memory buffer [skip ci] add copy methods in Java memory buffer [skip ci] Mar 31, 2021
@rongou
Copy link
Contributor Author

rongou commented Mar 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4d6ea76 into rapidsai:branch-0.19 Mar 31, 2021
@abellina
Copy link
Contributor

+1 thanks @rongou

@rongou rongou deleted the jni-copy branch November 23, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razajafri razajafri razajafri left review comments

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rongou @abellina @jlowe @razajafri