Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain dask and distributed versions to 2021.3.1 #7825

Merged
merged 3 commits into from
Apr 2, 2021
Merged

Constrain dask and distributed versions to 2021.3.1 #7825

merged 3 commits into from
Apr 2, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Apr 1, 2021

No description provided.

@shwina shwina requested review from a team as code owners April 1, 2021 21:40
@github-actions github-actions bot added conda Python Affects Python cuDF API. labels Apr 1, 2021
@shwina shwina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 1, 2021
kkraus14
kkraus14 reviewed Apr 1, 2021
View reviewed changes
python/dask_cudf/setup.py Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Should these just go into the integration repo?

@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 1, 2021

Should these just go into the integration repo?

We need them here for packaging and whatnot, but the integration package likely should pin Dask similarly.

@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #7825 (2a547ca) into branch-0.19 (7871e7a) will increase coverage by 0.79%.
The diff coverage is n/a.

❗ Current head 2a547ca differs from pull request most recent head e373e78. Consider uploading reports for the commit e373e78 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7825      +/-   ##
===============================================
+ Coverage        81.86%   82.66%   +0.79%     
===============================================
  Files              101      103       +2     
  Lines            16884    17584     +700     
===============================================
+ Hits             13822    14535     +713     
+ Misses            3062     3049      -13
Impacted Files Coverage Δ
python/cudf/cudf/utils/dtypes.py 83.44% <0.00%> (-6.08%) ⬇️
python/cudf/cudf/core/column/lists.py 87.32% <0.00%> (-4.08%) ⬇️
python/cudf/cudf/core/column/decimal.py 92.70% <0.00%> (-2.17%) ⬇️
python/dask_cudf/dask_cudf/backends.py 87.50% <0.00%> (-2.13%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.41% <0.00%> (-1.04%) ⬇️
python/cudf/cudf/core/column/column.py 87.63% <0.00%> (-0.13%) ⬇️
python/cudf/cudf/utils/utils.py 85.36% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 78.71% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7153bb...e373e78. Read the comment docs.

@kkraus14 kkraus14 added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 2, 2021
@kkraus14 kkraus14 changed the title Pin dask and distributed versions to 2021.3.1 Constrain dask and distributed versions to 2021.3.1 Apr 2, 2021
@kkraus14
Copy link
Collaborator

kkraus14 commented Apr 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 11358ce into rapidsai:branch-0.19 Apr 2, 2021
shwina added a commit to shwina/cudf that referenced this pull request Apr 7, 2021
@shwina
Constrain dask and distributed versions to 2021.3.1 (rapidsai#7825)
3355f82 
Authors:
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - Keith Kraus (https://github.com/kkraus14)
  - Mike Wendt (https://github.com/mike-wendt)

URL: rapidsai#7825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-wendt mike-wendt mike-wendt approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shwina @jakirkham @kkraus14 @mike-wendt