Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend range window queries to non-timestamp order-by columns #7866

Merged
merged 15 commits into from
Apr 29, 2021

Commits on Apr 5, 2021

  1. Initial range_window implementation:

    1. Enabled integral types. Some tests.
    2. Fixed unsigned.
    3. Tonnes of tests for nulls in orderby column
    4. Purged references to timestamps in range-window code.
    5. Tests for time scaling.
    6. Added tests for mean. Fixed sum test.
    7. Added collect tests.
    8. Tests for ASC/DESC timestamps, all aggs.
    9. Docs.
    10.Renamed the orderby null tests.
    11.Added range_window_bounds.hpp to meta.yaml.
    12.Review comments (std::move, CMakeLists)
    13.Better example for numeric range window function.
    14.Removed TODO, again.
    15.Formatting
    16.Added integral range tests.
    17.Removed scaling. Streamlined the dispatch logic.
    mythrocks committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    0af5be9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2021

  1. Configuration menu
    Copy the full SHA
    7a89ba6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69a3c31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c84502 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. Configuration menu
    Copy the full SHA
    8928ee1 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Configuration menu
    Copy the full SHA
    195d1f8 View commit details
    Browse the repository at this point in the history
  2. Rework from review:

    1. Fixed @copydoc.
    2. Added missing docs for range_window_bounds.
    3. Removed invariant. Inlined into constructor.
    mythrocks committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ed08ca5 View commit details
    Browse the repository at this point in the history
  3. Fix typo in @copydetails

    mythrocks committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    709e261 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Review comments:

    1. Fixed punctuation.
    2. Renamed add_and_check_overflow(), etc.
    3. Changed range_window_bounds default to unbounded.
    4. Removed test helper. Not reqd with C++17.
    mythrocks committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    83a05c8 View commit details
    Browse the repository at this point in the history
  2. Review comments:

    1. Use streams for calculating null-bounds.
    mythrocks committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    60a10f1 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Review comments:

    1. Explicit conversion from timestamp type to duration type.
    mythrocks committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    746068b View commit details
    Browse the repository at this point in the history
  2. Review comments:

    1. Cleaned up factory implementation, to make shared_ptr more apparent.
    2. Documentation
    mythrocks committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    309667b View commit details
    Browse the repository at this point in the history
  3. Review comments:

    1. Corrected docs for resolution of durations/timestamps.
    2. Fixed nitpick in motor-racing dataset.
    3. Switched bounds factory impl to use unique_ptr.
    4. assert_non_negative() now uses if constexpr.
    mythrocks committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    feb697d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    710cfec View commit details
    Browse the repository at this point in the history
  5. Removed extra ';'.

    mythrocks committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    d39aaf4 View commit details
    Browse the repository at this point in the history