-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend range window queries to non-timestamp order-by columns #7866
Merged
Commits on Apr 5, 2021
-
Initial range_window implementation:
1. Enabled integral types. Some tests. 2. Fixed unsigned. 3. Tonnes of tests for nulls in orderby column 4. Purged references to timestamps in range-window code. 5. Tests for time scaling. 6. Added tests for mean. Fixed sum test. 7. Added collect tests. 8. Tests for ASC/DESC timestamps, all aggs. 9. Docs. 10.Renamed the orderby null tests. 11.Added range_window_bounds.hpp to meta.yaml. 12.Review comments (std::move, CMakeLists) 13.Better example for numeric range window function. 14.Removed TODO, again. 15.Formatting 16.Added integral range tests. 17.Removed scaling. Streamlined the dispatch logic.
Configuration menu - View commit details
-
Copy full SHA for 0af5be9 - Browse repository at this point
Copy the full SHA 0af5be9View commit details
Commits on Apr 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7a89ba6 - Browse repository at this point
Copy the full SHA 7a89ba6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69a3c31 - Browse repository at this point
Copy the full SHA 69a3c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c84502 - Browse repository at this point
Copy the full SHA 6c84502View commit details
Commits on Apr 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8928ee1 - Browse repository at this point
Copy the full SHA 8928ee1View commit details
Commits on Apr 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 195d1f8 - Browse repository at this point
Copy the full SHA 195d1f8View commit details -
1. Fixed @copydoc. 2. Added missing docs for range_window_bounds. 3. Removed invariant. Inlined into constructor.
Configuration menu - View commit details
-
Copy full SHA for ed08ca5 - Browse repository at this point
Copy the full SHA ed08ca5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 709e261 - Browse repository at this point
Copy the full SHA 709e261View commit details
Commits on Apr 27, 2021
-
1. Fixed punctuation. 2. Renamed add_and_check_overflow(), etc. 3. Changed range_window_bounds default to unbounded. 4. Removed test helper. Not reqd with C++17.
Configuration menu - View commit details
-
Copy full SHA for 83a05c8 - Browse repository at this point
Copy the full SHA 83a05c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60a10f1 - Browse repository at this point
Copy the full SHA 60a10f1View commit details
Commits on Apr 28, 2021
-
1. Explicit conversion from timestamp type to duration type.
Configuration menu - View commit details
-
Copy full SHA for 746068b - Browse repository at this point
Copy the full SHA 746068bView commit details -
1. Cleaned up factory implementation, to make shared_ptr more apparent. 2. Documentation
Configuration menu - View commit details
-
Copy full SHA for 309667b - Browse repository at this point
Copy the full SHA 309667bView commit details -
1. Corrected docs for resolution of durations/timestamps. 2. Fixed nitpick in motor-racing dataset. 3. Switched bounds factory impl to use unique_ptr. 4. assert_non_negative() now uses if constexpr.
Configuration menu - View commit details
-
Copy full SHA for feb697d - Browse repository at this point
Copy the full SHA feb697dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 710cfec - Browse repository at this point
Copy the full SHA 710cfecView commit details -
Configuration menu - View commit details
-
Copy full SHA for d39aaf4 - Browse repository at this point
Copy the full SHA d39aaf4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.