Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic cudart for nvcomp in java build [skip-ci] #7896

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Use dynamic cudart for nvcomp in java build [skip-ci] #7896

merged 3 commits into from
Apr 7, 2021

Conversation

abellina
Copy link
Contributor

@abellina abellina commented Apr 7, 2021

This PR does two things:

  • It adds a check that will fail the build if it detects that CUDA runtime was linked statically. For now, that seems like a safe bet, and if we decide to start building with a static CUDA in the future, we should remove that check.
  • As part of investigation for [BUG] Pinned memory allocation within Parquet reader can be very slow #7600, libnvcomp was the last library that had a statically linked CUDA runtime, so this PR addresses that.

@github-actions github-actions bot added CMake CMake build issue Java Affects Java cuDF API. labels Apr 7, 2021
@abellina
Copy link
Contributor Author

abellina commented Apr 7, 2021

@jlowe this is in draft mode since I am still trying to run the ci manually. Let me know if you have concerns on this approach.

@abellina
Copy link
Contributor Author

abellina commented Apr 7, 2021

Note that cuInit is really the driver API, but with a dynamically linked cudart, it is not there.

@abellina abellina mentioned this pull request Apr 7, 2021
Closed
@abellina abellina marked this pull request as ready for review April 7, 2021 21:19
@abellina abellina requested a review from a team as a code owner April 7, 2021 21:19
@abellina
Copy link
Contributor Author

abellina commented Apr 7, 2021

@jlowe on a local build, the build-in-docker script didn't fail given that all was dynamic. I also ran unit tests locally (including nvcomp) with the dynamically linked cuda.

@abellina abellina added non-breaking Non-breaking change 3 - Ready for Review Ready for review by team bug Something isn't working labels Apr 7, 2021
@jlowe
Copy link
Member

jlowe commented Apr 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 58f395b into rapidsai:branch-0.19 Apr 7, 2021
@abellina abellina deleted the nvcomp_dynamic_cudart branch April 8, 2021 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abellina @jlowe