Switch from std::tie() to structured binding. #8117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythrocks
added
improvement
mythrocks
force-pushed
the
range-queries-20
branch
from
89bfd8a
to
84f40c8
Compare
vuule
approved these changes
Apr 30, 2021
|
Rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8117 +/- ##
===============================================
+ Coverage 82.88% 82.91% +0.02%
===============================================
Files 103 103
Lines 17668 17868 +200
===============================================
+ Hits 14645 14816 +171
- Misses 3023 3052 +29
Continue to review full report at Codecov.
|
cwharris
approved these changes
Apr 30, 2021
|
Glad we can work around the structured binding lambda capture limitations by naming captures explicitly! 😌 |
ttnghia
approved these changes
Apr 30, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addendum to #7866, to switch from using
std::tie()to structured bindings, as prescribed for C++17.This required workarounds for compiler restrictions on using aliases from structured bindings as captures in lambdas.