Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix cython flag to use c++17 #8243

Merged
merged 5 commits into from
May 14, 2021

Conversation

galipremsagar
Copy link
Contributor

This PR changes cython to compile with c++17

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels May 14, 2021
@galipremsagar galipremsagar self-assigned this May 14, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 14, 2021 00:14
@galipremsagar galipremsagar requested a review from isVoid May 14, 2021 00:14
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 14, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 14, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #8243 (1126a89) into branch-0.20 (51336df) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-0.20    #8243    +/-   ##
=============================================
  Coverage        82.88%   82.89%            
=============================================
  Files              103      105     +2     
  Lines            17668    17938   +270     
=============================================
+ Hits             14645    14870   +225     
- Misses            3023     3068    +45     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.47% <0.00%> (-2.46%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.17% <0.00%> (-0.56%) ⬇️
python/cudf/cudf/core/index.py 92.52% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
python/cudf/cudf/core/column/lists.py 87.09% <0.00%> (-0.32%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681211...1126a89. Read the comment docs.

@rapids-bot rapids-bot bot merged commit d206755 into rapidsai:branch-0.20 May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants