Make java rolling window operation APIs consistent [skip ci] #8251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
bug
mythrocks
reviewed
May 14, 2021
jlowe
approved these changes
May 14, 2021
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some recent changes to the rolling window java APIs that made it so there were multiple different ways to set preceding and following and they were inconsistent with each other. What is more if you used the wrong one, you got either the wrong answer or your program crashed with a seg fault trying to dereference a null pointer.
This removes the ambiguity, but it is a breaking change. Because of this I am going to keep this in draft until Monday.