Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review] CMake always explicitly specify a source files extension #8270

Merged
merged 1 commit into from
May 18, 2021
Merged

[Review] CMake always explicitly specify a source files extension #8270

merged 1 commit into from
May 18, 2021

Conversation

robertmaynard
Copy link
Contributor

While you can pass files without extensions to CMake this is legacy behavior that is now deprecated.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team CMake CMake build issue non-breaking Non-breaking change labels May 18, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner May 18, 2021 12:41
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 18, 2021
@robertmaynard
CMake always explicitly specify a source files extension
815907e 
While you can pass files without extensions to CMake this is
legacy behavior that is now deprecated.
@robertmaynard robertmaynard force-pushed the bug/explicitly_list_each_files_extension branch from 64d4f24 to 815907e Compare May 18, 2021 17:53
@robertmaynard robertmaynard mentioned this pull request May 18, 2021
Merged
@robertmaynard
Copy link
Contributor Author

@gpucibot merge

@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@59d8d5e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8270   +/-   ##
===============================================
  Coverage                ?   82.85%           
===============================================
  Files                   ?      105           
  Lines                   ?    17891           
  Branches                ?        0           
===============================================
  Hits                    ?    14823           
  Misses                  ?     3068           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d8d5e...815907e. Read the comment docs.

@rapids-bot rapids-bot bot merged commit bbce6bc into rapidsai:branch-21.06 May 18, 2021
@robertmaynard robertmaynard deleted the bug/explicitly_list_each_files_extension branch May 19, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @cwharris @hyperbolic2346