[WIP] Array refactor #8273
Closed
[WIP] Array refactor #8273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…column-methods-cleanup
rapids-bot bot
pushed a commit
that referenced
this pull request
May 26, 2021
…#8278) Adds a common parent class for NumericalColumn and DecimalColumn that implements the common operations (mainly reductions and scans). As part of enabling this, the _copy_type_metadata method was refactored to have different column types override it to perform column-specific tasks (necessary because DecimalColumn has some special handling), which should also provide some marginal performance improvements for methods that copy metadata. This PR (and some to follow) are designed to help simplify the ongoing [Array refactoring](#8273). Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Keith Kraus (https://github.com/kkraus14) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #8278
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
… and require `parent` argument (#8306) Prior to this PR, ColumnMethods takes a `column` argument as well as an optional `parent` argument. - When passed only a `column` argument, its methods return Columns. We have made use of this internally to do certain operations on Columns. - When passed a `parent` argument, its methods return objects of the type of the `parent`. This enables us to use the same class to implement accessor methods for both Series and Index. This PR makes it so that we only accept (and now require) a `parent` argument, simplifying the class and its usage. All instances of `ColumnMethods` being used internally have been replaced. Part of the [Array refactor](#8273). Authors: - Ashwin Srinath (https://github.com/shwina) Approvers: - https://github.com/brandon-b-miller - Michael Wang (https://github.com/isVoid) URL: #8306
|
Closing as this effort is currently on hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.