Add option to link Java bindings with Arrow dynamically [skip ci] #8307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
3 - Ready for Review
revans2
reviewed
May 21, 2021
jlowe
changed the title
|
rerun tests |
revans2
approved these changes
May 24, 2021
|
rerun tests |
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8300
Adds a Maven property,
CUDF_JNI_ARROW_STATIC, that can be used to specify the JNI bindings should be linked against the Arrow library dynamically. This defaults toOFFsince Arrow and its dependencies are not guaranteed to be available in the jar's environment, but this can be useful for cases where a developer has already built libcudf that dynamically links to Arrow and just wants to run Java tests within the same build environment without needing to rebuild libcudf with static Arrow.For example, building and testing the Java bindings with dynamically-linked Arrow can be done via: