Fixed documentation bug in groupby agg method #8325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
kkraus14
approved these changes
May 24, 2021
kkraus14
added
the
5 - Ready to Merge
|
Thanks for the fix, LGTM! |
|
@gpucibot merge |
|
I added another commit with similar non-functional documentation fix in the pipe method. Not sure, whether I should have added it to this pull request. |
|
That's perfectly fine, thanks for the fixes! |
|
rerun tests |
3 similar comments
|
rerun tests |
|
rerun tests |
|
rerun tests |
ttnghia
changed the title
|
Rerun tests. |
ttnghia
approved these changes
Jun 2, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8325 +/- ##
===============================================
Coverage ? 82.83%
===============================================
Files ? 109
Lines ? 17901
Branches ? 0
===============================================
Hits ? 14828
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
galipremsagar
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non-functional documentation update.
The output of the c column is missing in the result of the first example in agg method:
python/cudf/cudf/core/groupby/groupby.py
I added the values of the c columns.