Java: Support struct scalar [skip ci] #8327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
sperlingxx
added
feature request
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
jlowe
reviewed
May 24, 2021
revans2
reviewed
May 24, 2021
firestarman
reviewed
May 25, 2021
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
Signed-off-by: sperlingxx <lovedreamf@gmail.com>
sperlingxx
changed the title
|
Hi @revans2 @jlowe @firestarman, thanks for review! I updated this PR, adding the support of |
|
LGTM |
jlowe
reviewed
May 25, 2021
| } | ||
| return new Scalar(DType.STRUCT, makeStructScalar(childHandles, false)); | ||
| } finally { | ||
| IllegalStateException closeException = null; |
There was a problem hiding this comment.
This won't do what we want. If an exception is thrown from the try block then this finally block will still clobber that exception if any close() call fails. It needs something like this:
RuntimeException error = null;
try {
...
} catch (RuntimeException e) {
error = e;
} catch (Exception e) {
error = new RuntimeException(e);
} finally {
for (ColumnVector child : children) {
if (child != null) {
try {
child.close();
} catch (Exception e) {
if (error != null) {
error.addSuppressed(e);
} else {
error = new RuntimeException(e);
}
}
}
}
if (error != null) {
throw error;
}
}There was a problem hiding this comment.
Fixed. Thanks for the demo code!
revans2
reviewed
May 25, 2021
| // make sure the close process is exception-free | ||
| try { | ||
| child.close(); | ||
| } catch (Exception ignore) { |
There was a problem hiding this comment.
This has the same problem as up above we need to not just eat the exceptions but add them to the suppression list.
revans2
approved these changes
May 26, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current PR is to support struct scalar in Java package, which is required by spark-rapids (issue link). In detail, current PR introduces three new features: