Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitmask_tests.cpp host accessing device memory #8370

Merged
merged 6 commits into from
Jun 2, 2021

Conversation

davidwendt
Copy link
Contributor

This fixes an error in the cleanEndWord utility in the bitmask_tests.cpp source file. The code is trying to set the last remaining bits of a bitmask word by accessing the byte through a device pointer in host code. The end result was not actually being used so it appears the release compile optimized out the entire function. The expected segfault does occur in a debug build.
This PR corrects the logic to copy the last word, set the appropriate bits, and then copy the word back to the device buffer.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels May 26, 2021
@davidwendt davidwendt self-assigned this May 26, 2021
@davidwendt davidwendt requested a review from a team as a code owner May 26, 2021 19:20
@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@606d854). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8370   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606d854...f3f22d1. Read the comment docs.

@harrism harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 2, 2021
@harrism
Copy link
Member

harrism commented Jun 2, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 024baab into rapidsai:branch-21.08 Jun 2, 2021
@davidwendt davidwendt deleted the bug-bitmask-tests branch June 2, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants